❮

Fix obsoleted comments for function prototypes

  • Jump to comment-1
    guofenglinux@gmail.com2022-08-02T09:06:44+00:00
    While doing the search in [1], I spotted several places where the comments for the function prototypes are obsoleted. For instance, btree_desc() and btree_identify() are now located in nbtdesc.c but the comment in nbtxlog.h is still claiming they are in nbtxlog.c. Fix these places with the attached. With high possibility there are other places with this kind of obsoleted comments, but I don't know how to find them all :-(. Thanks Richard [1] https://www.postgresql.org/message-id/CAMbWs489%2Bu6P_9qMjABsse0dNNBr36MA1SX5Ss7yZ7TD86mfKQ%40mail.gmail.com
    • Jump to comment-1
      michael@paquier.xyz2022-08-02T10:25:49+00:00
      On Tue, Aug 02, 2022 at 05:06:44PM +0800, Richard Guo wrote: > While doing the search in [1], I spotted several places where the > comments for the function prototypes are obsoleted. For instance, > btree_desc() and btree_identify() are now located in nbtdesc.c but the > comment in nbtxlog.h is still claiming they are in nbtxlog.c. > > Fix these places with the attached. With high possibility there are > other places with this kind of obsoleted comments, but I don't know how > to find them all :-(. These declarations are linked to comments with their file paths, so making that automated looks rather complicated to me. I have looked at the surroundings without noticing anything obvious, so what you have caught here sounds fine to me, good catches :) -- Michael
      • Jump to comment-1
        michael@paquier.xyz2022-08-04T08:38:00+00:00
        On Tue, Aug 02, 2022 at 07:25:49PM +0900, Michael Paquier wrote: > These declarations are linked to comments with their file paths, so > making that automated looks rather complicated to me. I have looked > at the surroundings without noticing anything obvious, so what you > have caught here sounds fine to me, good catches :) Done as of 245e14e. -- Michael
        • Jump to comment-1
          guofenglinux@gmail.com2022-08-04T11:02:13+00:00
          On Thu, Aug 4, 2022 at 4:38 PM Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Aug 02, 2022 at 07:25:49PM +0900, Michael Paquier wrote: > > These declarations are linked to comments with their file paths, so > > making that automated looks rather complicated to me. I have looked > > at the surroundings without noticing anything obvious, so what you > > have caught here sounds fine to me, good catches :) > > Done as of 245e14e. Thank you Michael! Thanks Richard